fix: getPlainContent causes external content to be fetched #3193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
getPlainContent
renders the element usingjQuery
, which when an image is included in the content, causes this image to be fetched from the server unneccessarily.Impact can be seen for example when a post
excerpt
is present, either fromflarum/sticky
orianm/synopsis
. If several posts are stickied, or if synopsis is enabled, many images or videos, etc are fetched.Taking advice from @davwheat , I've refactored this util to not use jQuery at all.
Reviewers should focus on:
js
is not my strong suit, this appears to work, but please let me know if I've missed something!Necessity
Confirmed
composer test
).Required changes: