Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use revision versioner to allow custom asset versioning #3183

Merged
merged 4 commits into from
Dec 6, 2021

Conversation

luceos
Copy link
Member

@luceos luceos commented Dec 1, 2021

Changes proposed in this pull request:

Allows asset compilation to use a different version hasher implementation. This allows easier implementation of rev-manifest.json storage locations. Eg on our stack if we override where assets are stored, the rev-manifest.json is stored there too (s3). This causes each request to read from the s3 bucket as well. A better location for something like that would be either the settings table or redis. For normal local-file based Flarum instances, the default rev-manifest handler is sufficient.

Reviewers should focus on:

Is this okay?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@askvortsov1
Copy link
Member

Makes sense to me, but unfortunately we still have to stick with PHPDocs for class parameters until we fully drop 7.3.

Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert the property type to a docblock

@luceos
Copy link
Member Author

luceos commented Dec 2, 2021

Habit be bad, will do so asap.

@luceos
Copy link
Member Author

luceos commented Dec 3, 2021

Convert the property type to a docblock

Done, anything else?

@askvortsov1 askvortsov1 added this to the 1.2 milestone Dec 6, 2021
@askvortsov1 askvortsov1 merged commit 7bab6ed into master Dec 6, 2021
@askvortsov1 askvortsov1 deleted the dk/separate-revision-compiler branch December 6, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants