Use revision versioner to allow custom asset versioning #3183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Allows asset compilation to use a different version hasher implementation. This allows easier implementation of rev-manifest.json storage locations. Eg on our stack if we override where assets are stored, the rev-manifest.json is stored there too (s3). This causes each request to read from the s3 bucket as well. A better location for something like that would be either the settings table or redis. For normal local-file based Flarum instances, the default rev-manifest handler is sufficient.
Reviewers should focus on:
Is this okay?
Confirmed
composer test
).Required changes: