Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use calculated offset when loading page in PaginatedListState #3159

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Use calculated offset when loading page in PaginatedListState #3159

merged 1 commit into from
Nov 8, 2021

Conversation

askvortsov1
Copy link
Member

Fixes #3158

Changes proposed in this pull request:
Previously, the old offset was overriding the new one, so the same page was loaded over and over again.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

SychO9
SychO9 approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@askvortsov1 askvortsov1 merged commit e797276 into master Nov 8, 2021
@askvortsov1 askvortsov1 deleted the as/paginated-list-state-override-offset branch November 8, 2021 21:33
@jaspervriends jaspervriends mentioned this pull request Nov 25, 2021
Closed
matteocontrini pushed a commit to fibraclick/flarum-framework that referenced this pull request Nov 26, 2021
@askvortsov1 @matteocontrini
Use calculated offset when loading page in PaginatedListState (flarum…
2513f36 
…#3159)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

@SychO9 SychO9 SychO9 approved these changes

@tankerkiller125 tankerkiller125 Awaiting requested review from tankerkiller125

@dsevillamartin dsevillamartin Awaiting requested review from dsevillamartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrolling notification list infinitely repeats
3 participants
@askvortsov1 @davwheat @SychO9