Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3072
Changes proposed in this pull request:
This uses
Intl.PluralRules
for plural rules, and fixes a security vulnerability allowing JS injection through translation arguments.Vuln fix in underlying repo works by escaping HTML symbols in all user provided arguments that are strings or nested arrays of strings (since those could get flattened in).
Reviewers should focus on:
Tests for the vuln fix:
Anything I missed / that should be added?
Necessity
Confirmed
composer test
).