Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ItemList for DiscussionPage content #3004

Merged
merged 2 commits into from
Aug 21, 2021
Merged

Use ItemList for DiscussionPage content #3004

merged 2 commits into from
Aug 21, 2021

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Aug 8, 2021

Changes proposed in this pull request:

This PR uses ItemLists for the content of DiscussionPage content.

When writing my Ad Units extension, I found it very difficult to add ads around Flarum, especially in this area.

Reviewers should focus on:

Nothing in particular.

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@davwheat davwheat added this to the 1.1 milestone Aug 8, 2021
@davwheat davwheat self-assigned this Aug 8, 2021
askvortsov1
askvortsov1 approved these changes Aug 14, 2021
View reviewed changes
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

SychO9
SychO9 approved these changes Aug 21, 2021
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@davwheat davwheat merged commit 656cc35 into master Aug 21, 2021
@davwheat davwheat deleted the dw/discussionpage-itemlists branch August 21, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

@dsevillamartin dsevillamartin Awaiting requested review from dsevillamartin

Assignees

@davwheat davwheat

Labels
type/extensibility
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@davwheat @SychO9 @askvortsov1