Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert extend util to TypeScript #2928

Merged
merged 18 commits into from
Nov 8, 2021
Merged

Convert extend util to TypeScript #2928

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6f21fcf
WIP
dsevillamartin Jun 16, 2021
ea4f2ac
WIP
dsevillamartin Jun 16, 2021
cc3d56f
Move ExtendCallback straight to function declaration
dsevillamartin Jun 20, 2021
e59c217
Allow using file extension in core compat imports
dsevillamartin Jun 20, 2021
8597ec0
Add .ts file extension to extend imports for typings
dsevillamartin Jun 20, 2021
e4b0dd4
Use Parameters<T[K]> for callback args
dsevillamartin Jun 20, 2021
975fc36
Fix issues with RegExp
dsevillamartin Jun 20, 2021
ac1c7a6
Fix changes to proxifyCompat regex breaking non-core import paths
dsevillamartin Jun 20, 2021
392c0ac
Change <T[K]> to 'as T[K]' and use Parameters<T[K]> when setting obje…
dsevillamartin Jun 20, 2021
67ce00e
Don't use lookbehind (unsupported on Safari iOS)
dsevillamartin Jun 20, 2021
abfa463
Add missing typings for `this`
davwheat Aug 18, 2021
b417889
Move utility types to global types
davwheat Aug 20, 2021
3045958
Remove type from source
davwheat Aug 20, 2021
16566db
Reformat
davwheat Aug 20, 2021
ba79c55
Format
davwheat Aug 20, 2021
76efb98
Follow standard export pattern
davwheat Aug 20, 2021
4a50541
Remove semicolon
davwheat Aug 20, 2021
9c1fb86
Update regex strings
davwheat Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove type from source
  • Loading branch information
@davwheat @dsevillamartin
davwheat authored and dsevillamartin committed Oct 30, 2021
commit 30459589bdc0e6177c35089ef9f036817ee93fc3
7 changes: 0 additions & 7 deletions js/src/common/extend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
export type KeyOfType<T extends object, Type> = Exclude<
{
[K in keyof T]: T[K] extends Type ? K : never;
}[keyof T],
undefined
>;

/**
* Extend an object's method by running its output through a mutating callback
* every time it is called.
Expand Down