Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve discussion page canonical URL #2853

Merged
merged 6 commits into from
May 10, 2021
Merged

Improve discussion page canonical URL #2853

merged 6 commits into from
May 10, 2021

Commits on May 10, 2021

  1. Switch to ?page= discussion page canonical URL & fix no-JS pagination… 

    … buttons
    @dsevillamartin @askvortsov1
    dsevillamartin authored and askvortsov1 committed May 10, 2021
    Configuration menu
    Copy the full SHA
    03a1638 View commit details
    Browse the repository at this point in the history

  2. Apply fixes from StyleCI 

    [ci skip] [skip ci]
    @askvortsov1
    datitisev authored and askvortsov1 committed May 10, 2021
    Configuration menu
    Copy the full SHA
    cc7f464 View commit details
    Browse the repository at this point in the history

  3. Move hasNext/hasPrev logic to content class, unset canonical page if … 

    …page is 1
    @askvortsov1
    askvortsov1 committed May 10, 2021
    Configuration menu
    Copy the full SHA
    beb3195 View commit details
    Browse the repository at this point in the history

  4. Fix next/prev page links

    @askvortsov1
    askvortsov1 committed May 10, 2021
    Configuration menu
    Copy the full SHA
    ef5b9e6 View commit details
    Browse the repository at this point in the history

  5. DRY $near

    @askvortsov1
    askvortsov1 committed May 10, 2021
    Configuration menu
    Copy the full SHA
    09c0543 View commit details
    Browse the repository at this point in the history

  6. Apply fixes from StyleCI 

    [ci skip] [skip ci]
    @askvortsov1 @StyleCIBot
    askvortsov1 authored and StyleCIBot committed May 10, 2021
    Configuration menu
    Copy the full SHA
    de17dd7 View commit details
    Browse the repository at this point in the history