Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use all Mithril lifecycle stubs #2847

Merged
merged 5 commits into from
May 9, 2021
Merged

Use all Mithril lifecycle stubs #2847

merged 5 commits into from
May 9, 2021

Conversation

askvortsov1
Copy link
Member

See #2446

@askvortsov1 askvortsov1 linked an issue May 9, 2021 that may be closed by this pull request
Not having lifecycle method stubs on parent component create extensibility issues #2446
Closed
davwheat
davwheat reviewed May 9, 2021
View reviewed changes
js/src/forum/components/Search.js Outdated Show resolved Hide resolved
js/src/forum/components/PostStreamScrubber.js Outdated Show resolved Hide resolved
askvortsov1 and others added 2 commits May 9, 2021 17:01
@askvortsov1 @davwheat
Update js/src/forum/components/Search.js
90b63d4 
Co-authored-by: David Wheatley <hi@davwheat.dev>
@askvortsov1 @davwheat
Update js/src/forum/components/PostStreamScrubber.js
d13a0e8 
Co-authored-by: David Wheatley <hi@davwheat.dev>
@askvortsov1 askvortsov1 requested a review from davwheat May 9, 2021 21:01
clarkwinkelmann
clarkwinkelmann approved these changes May 9, 2021
View reviewed changes
Copy link
Member

@clarkwinkelmann clarkwinkelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested locally, but looks good to me 👍

Just one comment below about consistent formatting.

js/src/forum/components/Composer.js Show resolved Hide resolved
@askvortsov1 askvortsov1 merged commit d4e3254 into master May 9, 2021
@askvortsov1 askvortsov1 deleted the as/lifecycle-stubs branch May 9, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

@clarkwinkelmann clarkwinkelmann clarkwinkelmann approved these changes

@SychO9 SychO9 Awaiting requested review from SychO9

@tankerkiller125 tankerkiller125 Awaiting requested review from tankerkiller125

Assignees

@askvortsov1 askvortsov1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not having lifecycle method stubs on parent component create extensibility issues
3 participants
@askvortsov1 @clarkwinkelmann @davwheat