Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run API Client requests through middleware #2783

Merged
merged 27 commits into from
May 10, 2021
Merged

Run API Client requests through middleware #2783

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
e11f415
Add integration tests for login and registration
askvortsov1 Apr 12, 2021
b80c8e2
Use route name for API Client, run through simplified api middleware …
askvortsov1 Apr 12, 2021
8998d4d
Test that ThrottleApi applies to routes accessed via API client
askvortsov1 Apr 12, 2021
dc5de46
Apply fixes from StyleCI
askvortsov1 Apr 12, 2021
7c8ec13
Client pipe should be provided by service provider
askvortsov1 Apr 19, 2021
4704ded
Apply fixes from StyleCI
askvortsov1 Apr 19, 2021
2637a96
Make sure user isn't overriden in API Client middleware pipe
askvortsov1 Apr 20, 2021
35ad8e5
Apply fixes from StyleCI
askvortsov1 Apr 20, 2021
e872adf
Add request as param to API Client
askvortsov1 Apr 22, 2021
5bb9c87
reverse arg order
askvortsov1 Apr 22, 2021
4f241f0
Apply fixes from StyleCI
askvortsov1 Apr 22, 2021
fa0ef3b
Make middleware to exclude a singleton
askvortsov1 May 8, 2021
4cae57b
Apply fixes from StyleCI
askvortsov1 May 8, 2021
598aafa
Trigger CI
askvortsov1 May 8, 2021
2dfaec3
Alias cleanup
askvortsov1 May 8, 2021
d55f5b4
Restore getApiDocument functions to `protected`
askvortsov1 May 8, 2021
a9cb095
Fluent API, use route path instead of name
askvortsov1 May 9, 2021
f521cd0
Apply fixes from StyleCI
askvortsov1 May 9, 2021
5b27989
type fix
askvortsov1 May 9, 2021
30e57f3
Fix GET api client calls
askvortsov1 May 9, 2021
606c047
Don't always skip CSRF verification, make `send` public, remove unnec…
askvortsov1 May 9, 2021
6d72e91
Apply fixes from StyleCI
askvortsov1 May 9, 2021
f425d3d
Copy parent csrf header line
askvortsov1 May 9, 2021
7d62773
Restore csrf exemption for API client.
askvortsov1 May 9, 2021
2fc4f66
Remove unnecessary withParsedBody
askvortsov1 May 10, 2021
927c97f
Discussion ID might be string
askvortsov1 May 10, 2021
f229e7a
Update phpDoc
SychO9 May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
type fix
  • Loading branch information
@askvortsov1
askvortsov1 committed May 9, 2021
commit 5b2798901272120bd90aa838b6a6b6297930223a
2 changes: 1 addition & 1 deletion src/Forum/Content/Discussion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public function __invoke(Document $document, Request $request)
*
* @throws RouteNotFoundException
*/
protected function getApiDocument(Request $request, number $id, array $params)
protected function getApiDocument(Request $request, int $id, array $params)
askvortsov1 marked this conversation as resolved.
Show resolved Hide resolved
{
$params['bySlug'] = true;
$response = $this->api
Expand Down