Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use UrlGenerator in place of extracting the url from request #2674

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Use UrlGenerator in place of extracting the url from request #2674

merged 2 commits into from
Mar 16, 2021

Conversation

imorland
Copy link
Member

@imorland imorland commented Mar 8, 2021

Part 1 of #2673

askvortsov1
askvortsov1 requested changes Mar 8, 2021
View reviewed changes
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same suggestion as flarum/tags#122 (comment)

@askvortsov1 askvortsov1 merged commit 0e6a60b into flarum:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tankerkiller125 tankerkiller125 tankerkiller125 approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

@SychO9 SychO9 Awaiting requested review from SychO9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imorland @tankerkiller125 @askvortsov1