Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel components v8 #2576

Merged
merged 25 commits into from
Mar 5, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
c6a3c32
get response body
luceos Jan 27, 2021
d4bceff
update actions ci
luceos Jan 27, 2021
d0de12f
include json for 4 spaces tab
luceos Jan 27, 2021
4cb0b0a
update deps
luceos Jan 27, 2021
bfbb74a
provide output int for process code exit
luceos Jan 27, 2021
5feef61
adhere to parent type hint of builder
luceos Jan 27, 2021
be31a89
mailer instance now needs a name, multiple can be instantiated
luceos Jan 27, 2021
71eec54
getOriginal now uses mutators in the model
luceos Jan 27, 2021
1578869
assertRegExp => assertMatchesRegularExpression for phpunit
luceos Jan 27, 2021
cb158ae
return the actual return integer for exit in a cli process
luceos Jan 27, 2021
b8db6fd
ignore the phpunit cache file
luceos Jan 27, 2021
0ec5305
symfon 5+
luceos Feb 1, 2021
db4fd9d
re-add console
luceos Feb 1, 2021
75ea3ad
increase timeout
luceos Feb 1, 2021
a03b23d
green tests
luceos Feb 1, 2021
b6c0eaf
Apply fixes from StyleCI
luceos Feb 1, 2021
b96b067
Temporarily loosen MailableInterface requirements
askvortsov1 Feb 18, 2021
bf6cb74
Temporarily provide (and autoload) old symfony translator interface
askvortsov1 Feb 18, 2021
d3a5e84
Apply fixes from StyleCI
askvortsov1 Feb 18, 2021
aeddce6
make queue exception handler compatible with the contract of L8
luceos Mar 1, 2021
e7f29b1
remove all v in dep constraint
luceos Mar 3, 2021
eb28f52
Update phpunit schema for newer version
askvortsov1 Mar 5, 2021
6ba843f
More phpunit testcase tweaks for v9
askvortsov1 Mar 5, 2021
f8d3081
Merge branch 'master' into dk/illuminate-v8
askvortsov1 Mar 5, 2021
ca04328
Apply fixes from StyleCI
askvortsov1 Mar 5, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
green tests
  • Loading branch information
luceos authored and askvortsov1 committed Mar 3, 2021
commit a03b23dca2919fd09782dbee0d371d96ac3c9e29
2 changes: 1 addition & 1 deletion src/Api/Controller/SendConfirmationEmailController.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\RequestHandlerInterface;
use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;

class SendConfirmationEmailController implements RequestHandlerInterface
{
Expand Down
2 changes: 1 addition & 1 deletion src/Api/Controller/SendTestMailController.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\RequestHandlerInterface;
use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;

class SendTestMailController implements RequestHandlerInterface
{
Expand Down
2 changes: 1 addition & 1 deletion src/Api/Serializer/GroupSerializer.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

use Flarum\Group\Group;
use InvalidArgumentException;
use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;

class GroupSerializer extends AbstractSerializer
{
Expand Down
2 changes: 1 addition & 1 deletion src/Forum/Content/Index.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use Illuminate\Contracts\View\Factory;
use Illuminate\Support\Arr;
use Psr\Http\Message\ServerRequestInterface as Request;
use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;

class Index
{
Expand Down
2 changes: 1 addition & 1 deletion src/Forum/ForumServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
use Flarum\Settings\Event\Saving;
use Flarum\Settings\SettingsRepositoryInterface;
use Laminas\Stratigility\MiddlewarePipe;
use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;

class ForumServiceProvider extends AbstractServiceProvider
{
Expand Down
2 changes: 1 addition & 1 deletion src/Foundation/AbstractValidator.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
use Illuminate\Support\Arr;
use Illuminate\Validation\Factory;
use Illuminate\Validation\ValidationException;
use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;

abstract class AbstractValidator
{
Expand Down
2 changes: 1 addition & 1 deletion src/Foundation/ErrorHandling/ViewFormatter.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
use Laminas\Diactoros\Response\HtmlResponse;
use Psr\Http\Message\ResponseInterface as Response;
use Psr\Http\Message\ServerRequestInterface as Request;
use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;

/**
* A formatter for turning caught exceptions into "pretty" HTML error pages.
Expand Down
4 changes: 3 additions & 1 deletion src/Locale/LocaleServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
use Flarum\Settings\SettingsRepositoryInterface;
use Illuminate\Contracts\Events\Dispatcher;
use Illuminate\Contracts\Translation\Translator as TranslatorContract;
use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;
use Symfony\Component\Translation\TranslatorInterface as DeprecatedTranslatorInterface;

class LocaleServiceProvider extends AbstractServiceProvider
{
Expand Down Expand Up @@ -65,6 +66,7 @@ public function register()
$this->app->alias('translator', Translator::class);
$this->app->alias('translator', TranslatorContract::class);
$this->app->alias('translator', TranslatorInterface::class);
$this->app->alias('translator', DeprecatedTranslatorInterface::class);
}

private function getDefaultLocale(): string
Expand Down
5 changes: 5 additions & 0 deletions src/Locale/Translator.php
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,9 @@ private function getTranslation(MessageCatalogueInterface $catalogue, $id, $doma

return $translation;
}

public function setLocale($locale)
{
parent::setLocale($locale);
}
}
2 changes: 1 addition & 1 deletion src/Notification/MailableInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace Flarum\Notification;

use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;

interface MailableInterface
{
Expand Down
2 changes: 1 addition & 1 deletion src/Notification/NotificationMailer.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
use Flarum\User\User;
use Illuminate\Contracts\Mail\Mailer;
use Illuminate\Mail\Message;
use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;

class NotificationMailer
{
Expand Down
2 changes: 1 addition & 1 deletion src/User/AccountActivationMailer.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
use Flarum\Settings\SettingsRepositoryInterface;
use Flarum\User\Event\Registered;
use Illuminate\Contracts\Queue\Queue;
use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;

class AccountActivationMailer
{
Expand Down
2 changes: 1 addition & 1 deletion src/User/Command/RequestPasswordResetHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use Illuminate\Contracts\Validation\Factory;
use Illuminate\Database\Eloquent\ModelNotFoundException;
use Illuminate\Validation\ValidationException;
use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;

class RequestPasswordResetHandler
{
Expand Down
2 changes: 1 addition & 1 deletion src/User/EmailConfirmationMailer.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
use Flarum\Settings\SettingsRepositoryInterface;
use Flarum\User\Event\EmailChangeRequested;
use Illuminate\Contracts\Queue\Queue;
use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;

class EmailConfirmationMailer
{
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/extenders/EventTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use Flarum\User\User;
use Illuminate\Contracts\Bus\Dispatcher as BusDispatcher;
use Illuminate\Contracts\Events\Dispatcher;
use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Contracts\Translation\TranslatorInterface;

class EventTest extends TestCase
{
Expand Down