-
-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Notification Channel Extender #2432
Add Notification Channel Extender #2432
Conversation
One interesting point brought up by flarum/pusher#28 is that each driver will end up queing its own, independent jobs. Do we want to split it up like this, or move the logic for running through the drivers to inside the event? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good code-wise.
I see the tests only test against the container bindings, not for the actual sending of notifications.
I'd love to see this tested with an actual use case, like the Telegram notifications of the Telegram login extension before being shipped, so we make sure we ship something that will be practical in the real world. Or was a test already performed on another real world extension?
Do you mean in the integration tests? If you mean manual testing, I'm planning to test this with my PWA extension before merging |
there's technically also the pusher extension which I tested on (if that counts). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this works with my PWA extension, for both preferences and actually sending notifications.
Fixes #2419
Changes proposed in this pull request:
Flarum\Notification\Event\Sending
Event.Reviewers should focus on:
Confirmed
composer test
).Required changes: