-
-
Notifications
You must be signed in to change notification settings - Fork 857
Fix routing forced refresh #2382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Makes Discussion Page route work without diffing.
Regarding the links here are the options:
When setting routes programmatically, the default behavior will be to just diff, if the URL is identical. One can use the |
I prefer option 1. With the changes in #2378, that behavior is recovered where relevant. The only change I'd make is for LinkButtons to have Also, when trying out #2378, |
Let's close this, it seems to work now more or less. The only thing that's weird is that the site refreshes for me on https://nightly.flarum.site, but not when I run it locally. |
Fixes the following issue:
Depends on #2378. Going to rebase after it's merged.
Changes proposed in this pull request:
Use the route resolver
onmatch
method to check if links have requested a forced refresh.Reviewers should focus on:
Do we want to make the force refresh the default for links created with the
Link
component?Confirmed