Minor improvements to onNewRoute #2328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call onNewRoute when page changed with same component in DiscussionPage and UserPage
Make app.previous and app.current changed in onNewRoute, not in oninit. This way, when the route is changed, but still handled by the same component, a new PageState object will still be created.
1 task
askvortsov1
requested review from
clarkwinkelmann,
dsevillamartin and
franzliedke
|
On its own, does this diff introduce any change of behavior? Does it change anything in regard to the navigation history? Does it make sense to call |
|
Not to navigation history, but if you go from one discussions page to another discussions page, app.current and app.previous will more accurately reflect that, instead of acting like we never left the page. And yeah, those can be condensed into one argument. Will do. |
tankerkiller125
approved these changes
Oct 1, 2020
clarkwinkelmann
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
app.previousandapp.currentfromoninittoonNewRoute(inspired by Abort requests on route change #2319 (comment))onbeforeupdatefor DiscussionPage and UserPage as well as in IndexPage (so that several visits to DiscussionPage in a row don't count as one "PageState".This also sets us up for possible changes like #2275 (comment)