Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added alt attribute to avatar's img tag #2269

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Added alt attribute to avatar's img tag #2269

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f98e63
Added alt attribute to avatar's img tag
smartclash Aug 20, 2020
87c5c7e
Make the alt attribute be empty
smartclash Aug 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make the alt attribute be empty
  • Loading branch information
@smartclash
smartclash committed Aug 25, 2020
commit 87c5c7e627c607461d92c698a5d1b9f4da6cc008
2 changes: 1 addition & 1 deletion js/src/common/helpers/avatar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default function avatar(user, attrs = {}) {
if (hasTitle) attrs.title = attrs.title || username;

if (avatarUrl) {
return <img {...attrs} src={avatarUrl} alt={username} />;
return <img {...attrs} src={avatarUrl} alt="" />;
}

content = username.charAt(0).toUpperCase();
Expand Down