Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fixed issue with the Js compiler being unable to use the system tmp d…
…irectory, using the one in storage is much safer across different operating systems
- Loading branch information
54660eb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So does this fix #487?
54660eb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks yes, after your message I went over all instances of core to seek additional references. What I did notice is mixed use of storage_path (which uses DIRECTORY_SEPARATOR) and the Application::storage_path method which allows no arguments. Which do we prefer?
54660eb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to avoid the global helpers where possible.
54660eb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too, I guess we should get rid of them soon then. I'll set up an issue for that.