-
-
Notifications
You must be signed in to change notification settings - Fork 130
Update Chinese docs & some improvement #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Add Chinese searchPlaceholder(#0d617c2) 2. Add Chinese docs(extend/start.md) 3. Correct the reversed component name. 4. Add Chinese font. 5. Fix wrong sentences in `zh/contributing.md`.
Merge pull request #1 from flarum/master (Sync docs with main repository)
1. Update /README.md 2. Sync #ca96df0 : /extend/start.md 3. Update /install.md (#160) : Add PHP8 prompt 4. Update /contributing.md: fix typo
docs/install.md
Outdated
::: vue | ||
`Default directory structure` | ||
|
||
. Flarum web root | ||
├── public | ||
│ ├── assets _(**static assets, css, avators, uploaded files, etc.**)_ | ||
│ └── .htaccess | ||
│ | ||
├── storage | ||
│ └── logs _(**flarum error logs**)_ | ||
│ | ||
├── vendor _(**flarum core, extensions**)_ | ||
├── .nginx.conf _(**Nginx pseudo-static file**)_ | ||
├── composer.json | ||
├── extend.php | ||
├── flarum | ||
├── LICENSE | ||
├── README.md | ||
└── site.php | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add default directory structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for putting this together! Sorry for the delay in reviewing.
is_processing = true; | ||
break; | ||
case 'tr': | ||
outdated_tip = 'The translation of this page may not be up to date, please refer to the <a>English document</a> for the latest information. If there is a problem with the translation, please <a>let us know</a>.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to use translated text for these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't speak Turkish, maybe we can ask @DursunCanPoyraz to translate it later
docs/install.md
Outdated
@@ -109,6 +109,27 @@ You should never set any folder or file to permission level `777`, as this permi | |||
|
|||
By default Flarum's directory structure includes a `public` directory which contains only publicly-accessible files. This is a security best-practice, ensuring that all sensitive source code files are completely inaccessible from the web root. | |||
|
|||
::: vue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is the best place for this. Maybe under 'Installing' would be better? Also, this might be better in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sonds good, I'll do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change has been reverted
<template> | ||
<outdated class="blue"></outdated> | ||
</template> | ||
|
||
# 故障排查 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could these be removed from other language files so they don't appear twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other language files haven't used this template yet, so the notification will appear once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it being used in the Italian version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it isn't. I searched this template code in Italian doc, and found nothing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it locally, but it all looks good to me.
Uh oh!
There was an error while loading. Please reload this page.