Skip to content

Commit

Permalink
Remove expando that we were adding to portal container
Browse files Browse the repository at this point in the history
**what is the change?:**
see title

**why make this change?:**
this is part of an old approach to detecting portals, and we have
instead added a check in the `findHostInstance` method to filter out
portals.

**test plan:**
`yarn test`

**issue:**
facebook#8854
  • Loading branch information
flarnie committed Jul 20, 2017
1 parent 0b0035c commit 178e1a4
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/renderers/shared/fiber/ReactFiberCommitWork.js
Original file line number Diff line number Diff line change
Expand Up @@ -218,10 +218,6 @@ module.exports = function<T, P, I, TI, PI, C, CX, PL>(
}
} else {
if (isContainer) {
if (parentFiber.tag === HostPortal) {
// allows us to identify the portal container in other places
parent.__reactInternalIsPortalContainer = true;
}
appendChildToContainer(parent, node.stateNode);
} else {
appendChild(parent, node.stateNode);
Expand Down

0 comments on commit 178e1a4

Please sign in to comment.