fix(docs): update from london to shanghai fork #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikerzetic-aflabs
force-pushed
the
flare-fork
branch
from
013640d to
8961a59
Compare
fassko
requested changes
Aug 7, 2025
| @@ -105,31 +105,31 @@ In addition to the `randomNumber` itself, two other variables are retrieved: | |||
|
|
|||
| - `timestamp`: The UNIX timestamp marking the end of the voting epoch during which data was collected from data providers to generate the specific number. Each voting epoch lasts for a fixed 90-second window. | |||
|
|
|||
| :::warning[Set EVM Version to London] | |||
| :::warning[Set EVM Version to shanghai] | |||
There was a problem hiding this comment.
Capitalize shanghai
Suggested change
| :::warning[Set EVM Version to shanghai] | |
| :::warning[Set EVM Version to Shanghai] |
AmadiaFlare
requested changes
Aug 7, 2025
| @@ -132,7 +132,7 @@ If you have not already configured your MetaMask wallet to support Flare Testnet | |||
|
|
|||
| <img src={OpenSolidityCompiler} style={{ width: 300 }} /> | |||
|
|
|||
| 3. Expand the **Advanced Configurations** section and make sure the **EVM Version** is set to `london`. | |||
| 3. Expand the **Advanced Configurations** section and make sure the **EVM Version** is set to `shanghai`. | |||
|
|
|||
| <img src={SetEvmVersion} style={{ width: 300 }} /> | |||
There was a problem hiding this comment.
Need a new screenshot here changing to shanghai on Remix
| @@ -120,7 +120,7 @@ Let's break down the `HelloWorld` contract: | |||
|
|
|||
| <img src={OpenSolidityCompiler} style={{ width: 300 }} /> | |||
|
|
|||
| 4. Expand the **Advanced Configurations** section and make sure the **EVM Version** is set to `london`. | |||
| 4. Expand the **Advanced Configurations** section and make sure the **EVM Version** is set to `shanghai`. | |||
|
|
|||
| <img src={SetEvmVersion} style={{ width: 300 }} /> | |||
There was a problem hiding this comment.
Need new screenshot here for changing remix to shanghai
nikerzetic-aflabs
force-pushed
the
flare-fork
branch
from
8961a59 to
71d5fc5
Compare
AmadiaFlare
requested changes
Aug 8, 2025
|
|
||
| - **Using Remix:** Set EVM version to `london` in the **Advanced Configurations** section of the **Solidity Compiler** tab: | ||
| - **Using Remix:** Set EVM version to `shanghai` in the **Advanced Configurations** section of the **Solidity Compiler** tab: | ||
|
|
||
| <img src={SetEvmVersionRemix} style={{ width: 300 }} /> |
There was a problem hiding this comment.
Need new source image for remix showing switch to shanghai
|
|
||
| - **Using Remix:** Set EVM version to `london` in the **Advanced Configurations** section of the **Solidity Compiler** tab: | ||
| - **Using Remix:** Set EVM version to `shanghai` in the **Advanced Configurations** section of the **Solidity Compiler** tab: | ||
|
|
||
| {" "} | ||
|
|
||
| <img src={SetEvmVersionRemix} style={{ width: 300 }} /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.