-
Notifications
You must be signed in to change notification settings - Fork 27
Description
See issue 1067 in gdsfactory
How easy would it be for sax.circuit to also account for interfaces between components?
I am thinking a flag that, if True,
(1) requires the user to provide models for component pairs that show up connected in the graph
(2) adds a component evaluating these models at every "connection" of the netlist
The obvious use case is to model reflections in direct transitions between waveguides with different widths or bend radii. Currently gdsfactory+SAX throws a critical warning for the former, and evaluates the second without mode mismatch reflections.
Maybe this should be added as an option in gdsfactory.get_netlist()?
Example of desired behaviour for bend --> coupler --> straight :
Input:
circuit, _ = sax.circuit(c.get_netlist(), models=models, interfaces=True)
Output:
"Given Models": [],
"Required Models": ["bend_circular", "coupler_full", "straight"],
"Required Interface Models": [("bend_circular:o2", "coupler_full:o1"), ("coupler_full:o3", "straight:o1")],
If there were open-source EMEs around the required reflection matrices would be very easy to calculate :)