Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Replaced binary compaction metrics with more informative metrics that show actual compaction frequency and queue load by hook.
What this PR does / why we need it
Old metrics (removed):
tasks_queue_compaction_in_queue_tasks{queue_name, task_id}- showed task count per compaction IDtasks_queue_compaction_reached{queue_name, task_id}- showed only 0 or 1 when reaching cap thresholdThese metrics had limited value as they only indicated whether compaction threshold was reached, without showing actual queue load or compaction activity.
New metrics (added):
tasks_queue_compaction_operations_total{queue_name, hook}- counter showing how many times compaction ran for each hooktasks_queue_compaction_tasks_by_hook{queue_name, hook}- gauge showing actual number of pending tasks per hook (when >20)Why this is better:
hookname instead oftask_id, making it easy to identify problematic hooksSpecial notes for your reviewer