-
Notifications
You must be signed in to change notification settings - Fork 24
2246-Permissions #2300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mainawycliffe
wants to merge
14
commits into
main
Choose a base branch
from
2246-Permissions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
2246-Permissions #2300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
6cf8e50 to
47f39ac
Compare
47f39ac to
ab948b2
Compare
ab948b2 to
0366800
Compare
dce868a to
3745f16
Compare
d4864f5 to
b71c3ef
Compare
b71c3ef to
1d2cd40
Compare
b38d560 to
cfffab8
Compare
cfffab8 to
52488b8
Compare
52488b8 to
e859454
Compare
e859454 to
a621765
Compare
This will allow us to add connection form
Fixes #2246 chore: enable hiding resource column fix: make minor adjustments to resource display
Fixes #2246 fix: fix minor issues related to the permissions tab fix: fix failing tests and hard delete permissions fix: don't allow deleting of crd source permissions fix: fix failing test feat: add form for adding permissions in resource and fix form issues Fixes #2246 fix: fix failing build due to removed search layout component
fix: fix failing tests
chore: make improvements to permissions Update src/components/Permissions/ManagePermissions/Forms/PermissionForm.tsx Co-authored-by: Moshe Immerman <moshe@flanksource.com> Update src/components/Permissions/ManagePermissions/Forms/FormikPermissionSelectResourceFields.tsx Co-authored-by: Moshe Immerman <moshe@flanksource.com> Update src/components/Permissions/ManagePermissions/Forms/DeletePermission.tsx Co-authored-by: Moshe Immerman <moshe@flanksource.com> Update src/components/Permissions/ManagePermissions/Forms/FormikPermissionSelectResourceFields.tsx Co-authored-by: Moshe Immerman <moshe@flanksource.com> Update src/components/Permissions/ManagePermissions/Forms/FormikPermissionSelectResourceFields.tsx Co-authored-by: Moshe Immerman <moshe@flanksource.com> Update src/components/Permissions/ManagePermissions/Forms/PermissionForm.tsx Co-authored-by: Moshe Immerman <moshe@flanksource.com>
Update src/components/Connections/ConnectionFormModal.tsx Co-authored-by: Moshe Immerman <moshe@flanksource.com>
a621765 to
24af992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Fixes #2246