Check for constrains C741 through C749 #1100
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3680,7 +3680,7 @@ bool DeclarationVisitor::Pre(const parser::DerivedTypeDef &x) { | |
| if (symbol->has<TypeParamDetails>() && !paramNames.count(name)) { | ||
| SayDerivedType(name, | ||
| "'%s' is not a type parameter of this derived type"_err_en_US, | ||
| currScope()); // C741 | ||
| } | ||
| } | ||
| Walk(std::get<std::list<parser::Statement<parser::PrivateOrSequence>>>(x.t)); | ||
|
|
@@ -3821,14 +3821,36 @@ void DeclarationVisitor::Post(const parser::ComponentDecl &x) { | |
| !attrs.HasAny({Attr::PUBLIC, Attr::PRIVATE})) { | ||
| attrs.set(Attr::PRIVATE); | ||
| } | ||
| if (const auto *declType{GetDeclTypeSpec()}) { | ||
| if (const auto *derived{declType->AsDerived()}) { | ||
| if (!attrs.HasAny({Attr::POINTER, Attr::ALLOCATABLE})) { | ||
| if (derivedTypeInfo_.type == &derived->typeSymbol()) { // C744 | ||
| Say("Recursive use of the derived type requires " | ||
| "POINTER or ALLOCATABLE"_err_en_US); | ||
| } | ||
| } | ||
| if (!coarraySpec().empty()) { // C747 | ||
| if (IsTeamType(derived)) { | ||
| Say("A coarray component may not be of type TEAM_TYPE from " | ||
| "ISO_FORTRAN_ENV"_err_en_US); | ||
| } else { | ||
| if (IsIsoCType(derived)) { | ||
| Say("A coarray component may not be of C_PTR or C_FUNPTR from " | ||
|
There was a problem hiding this comment. Missing the word "type", or needs rewording. There was a problem hiding this comment. Thanks for catching this. I'll fix it. |
||
| "ISO_C_BINDING when an allocatable object is a " | ||
| "coarray"_err_en_US); | ||
| } | ||
| } | ||
| } | ||
| if (FindCoarrayUltimateComponent(*derived)) { // C748 | ||
| if (attrs.HasAny({Attr::POINTER, Attr::ALLOCATABLE})) { | ||
| Say("A component whose type has a coarray ultimate component " | ||
| "cannot be a POINTER or ALLOCATABLE"_err_en_US); | ||
|
There was a problem hiding this comment. We have mostly been using "may not" rather than "cannot". There was a problem hiding this comment. I also use "must not", but I shouldn't -- "may" is the correct modal verb here, since we're talking about what's allowed, not what might be possible. You might as well capture the result of There was a problem hiding this comment. Thanks. I'll fix it. There was a problem hiding this comment. I notice that there are many uses of the word "cannot" in resolve-names.cpp. @tskeith, should I fix them all in this pull request? There was a problem hiding this comment. I think it makes more sense to change them in a separate pull request, but if you want to do it in this one that's okay too. There was a problem hiding this comment. I think I'll wait. |
||
| } | ||
| if (!arraySpec().empty() || !coarraySpec().empty()) { | ||
| Say("A component whose type has a coarray ultimate component " | ||
| "cannot be an array or corray"_err_en_US); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| if (OkToAddComponent(name)) { | ||
|
|
@@ -4742,7 +4764,7 @@ Symbol *DeclarationVisitor::MakeTypeSymbol( | |
| const SourceName &name, Details &&details) { | ||
| Scope &derivedType{currScope()}; | ||
| CHECK(derivedType.IsDerivedType()); | ||
| if (auto *symbol{FindInScope(derivedType, name)}) { // C742 | ||
| Say2(name, | ||
| "Type parameter, component, or procedure binding '%s'" | ||
| " already defined in this type"_err_en_US, | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| ! RUN: %B/test/Semantics/test_errors.sh %s %flang %t | ||
| ! C746, C747, and C748 | ||
| module m | ||
| use ISO_FORTRAN_ENV | ||
| use ISO_C_BINDING | ||
|
|
||
| ! C746 If a coarray-spec appears, it shall be a deferred-coshape-spec-list and | ||
| ! the component shall have the ALLOCATABLE attribute. | ||
|
|
||
| type testCoArrayType | ||
| real, allocatable, codimension[:] :: allocatableField | ||
| !ERROR: Coarray components must be ALLOCATABLE and have a deferred coshape | ||
| real, codimension[:] :: deferredField | ||
| !ERROR: 'pointerfield' may not have the POINTER attribute because it is a coarray | ||
| !ERROR: Coarray components must be ALLOCATABLE and have a deferred coshape | ||
|
There was a problem hiding this comment. It would be nice if the wording of these two messages were similar. For example, the second could be: There was a problem hiding this comment. Sounds good. I'll change it. |
||
| real, pointer, codimension[:] :: pointerField | ||
| !ERROR: Coarray components must be ALLOCATABLE and have a deferred coshape | ||
| real, codimension[*] :: realField | ||
| end type testCoArrayType | ||
|
|
||
| ! C747 If a coarray-spec appears, the component shall not be of type C_PTR or | ||
| ! C_FUNPTR from the intrinsic module ISO_C_BINDING (18.2), or of type | ||
| ! TEAM_TYPE from the intrinsic module ISO_FORTRAN_ENV (16.10.2). | ||
|
|
||
| type goodCoarrayType | ||
| real, allocatable, codimension[:] :: field | ||
| end type goodCoarrayType | ||
|
|
||
| type goodTeam_typeCoarrayType | ||
| type(team_type), allocatable :: field | ||
| end type goodTeam_typeCoarrayType | ||
|
|
||
| type goodC_ptrCoarrayType | ||
| type(c_ptr), allocatable :: field | ||
| end type goodC_ptrCoarrayType | ||
|
|
||
| type goodC_funptrCoarrayType | ||
| type(c_funptr), allocatable :: field | ||
| end type goodC_funptrCoarrayType | ||
|
|
||
| type team_typeCoarrayType | ||
| !ERROR: A coarray component may not be of type TEAM_TYPE from ISO_FORTRAN_ENV | ||
| type(team_type), allocatable, codimension[:] :: field | ||
| end type team_typeCoarrayType | ||
|
|
||
| type c_ptrCoarrayType | ||
| !ERROR: A coarray component may not be of C_PTR or C_FUNPTR from ISO_C_BINDING when an allocatable object is a coarray | ||
| type(c_ptr), allocatable, codimension[:] :: field | ||
| end type c_ptrCoarrayType | ||
|
|
||
| type c_funptrCoarrayType | ||
| !ERROR: A coarray component may not be of C_PTR or C_FUNPTR from ISO_C_BINDING when an allocatable object is a coarray | ||
| type(c_funptr), allocatable, codimension[:] :: field | ||
| end type c_funptrCoarrayType | ||
|
|
||
| ! C748 A data component whose type has a coarray ultimate component shall be a | ||
| ! nonpointer nonallocatable scalar and shall not be a coarray. | ||
|
|
||
| type coarrayType | ||
| real, allocatable, codimension[:] :: goodCoarrayField | ||
| end type coarrayType | ||
|
|
||
| type testType | ||
| type(coarrayType) :: goodField | ||
| !ERROR: A component whose type has a coarray ultimate component cannot be a POINTER or ALLOCATABLE | ||
| type(coarrayType), pointer :: pointerField | ||
| !ERROR: A component whose type has a coarray ultimate component cannot be a POINTER or ALLOCATABLE | ||
| type(coarrayType), allocatable :: allocatableField | ||
| !ERROR: A component whose type has a coarray ultimate component cannot be an array or corray | ||
| type(coarrayType), dimension(3) :: arrayField | ||
| end type testType | ||
|
|
||
| end module m | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the message should say "and have a deferred coshape" unless it doesn't have a deferred coshape.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or just combine the tests and use the second message, it's got all the information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Tim. I'll change the code to remove that phrase when it doesn't apply.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@klausler, I think it's a little confusing to have the message tell the user that the declaration must have a deferred coshape when it already has one. I plan to stick with Tim's suggestion.