Skip to content

refactor: changed hardcoded stages ids #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
osantana85 merged 1 commit into from
Jan 12, 2026
Merged

refactor: changed hardcoded stages ids #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...ore-commons/src/main/java/io/flamingock/internal/common/core/pipeline/PipelineHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
import org.jetbrains.annotations.NotNull;

public class PipelineHelper {

public static final String SYSTEM_STAGE_ID = "flamingock-system-stage";
public static final String LEGACY_STAGE_ID = "flamingock-legacy-stage";

private static final String errorTemplate = "importing change with id[%s] from database. It must be imported to a flamingock stage";

private final PipelineDescriptor pipelineDescriptor;
Expand All @@ -29,7 +33,7 @@ public PipelineHelper(PipelineDescriptor pipelineDescriptor) {

public String getStageId(AuditEntry auditEntryFromOrigin) {
if (Boolean.TRUE.equals(auditEntryFromOrigin.getSystemChange())) {
return "mongock-legacy-system-changes";
return LEGACY_STAGE_ID;
} else {
String taskIdInPipeline = getBaseTaskId(auditEntryFromOrigin);
return pipelineDescriptor.getStageByTask(taskIdInPipeline).orElseThrow(() -> generateTaskIdException(taskIdInPipeline));
Expand Down
12 changes: 7 additions & 5 deletions ...k-processor/src/main/java/io/flamingock/core/processor/FlamingockAnnotationProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import io.flamingock.core.processor.util.PathResolver;
import io.flamingock.core.processor.util.ProjectRootDetector;
import io.flamingock.internal.common.core.metadata.FlamingockMetadata;
import io.flamingock.internal.common.core.pipeline.PipelineHelper;
import io.flamingock.internal.common.core.preview.CodePreviewChange;
import io.flamingock.internal.common.core.preview.PreviewPipeline;
import io.flamingock.internal.common.core.preview.PreviewStage;
Expand Down Expand Up @@ -371,10 +372,10 @@ private PreviewPipeline buildPipelineFromAnnotation(EnableFlamingock pipelineAnn

private Optional<SystemPreviewStage> buildSystemStageIfNeeded(List<CodePreviewChange> systemChanges) {
if(!systemChanges.isEmpty()) {
logger.verbose("Building stage: SystemStage");
logger.verbose("Building stage: " + PipelineHelper.SYSTEM_STAGE_ID);
// For system stage, use hardcoded name, description, package and resource dir to maintain consistency
SystemPreviewStage systemStage = PreviewStage.systemBuilder()
.setName("SystemStage")
.setName(PipelineHelper.SYSTEM_STAGE_ID)
.setDescription("Dedicated stage for system-level changes")
.setSourcesRoots(sourceRoots)
.setSourcesPackage(null)
Expand Down Expand Up @@ -433,8 +434,9 @@ private PreviewStage mapAnnotationToStage(Map<String, List<CodePreviewChange>> c

private Optional<PreviewStage> buildLegacyStageIfNeeded(List<CodePreviewChange> legacyChanges) {
if (legacyChanges != null && !legacyChanges.isEmpty()) {
logger.verbose("Building stage: " + PipelineHelper.LEGACY_STAGE_ID);
PreviewStage flamingockLegacyStage = PreviewStage.defaultBuilder(StageType.LEGACY)
.setName("legacy-stage")
.setName(PipelineHelper.LEGACY_STAGE_ID)
.setDescription("Flamingock legacy stage")
.setSourcesRoots(sourceRoots)
.setSourcesPackage(null) //TODO:
Expand Down Expand Up @@ -555,7 +557,7 @@ private SystemPreviewStage mapToSystemStage(Map<String, List<CodePreviewChange>>
throw new RuntimeException("System stage in YAML pipeline requires a 'location' field. Please specify the location where changes are found.");
}

logger.verbose("Building stage: SystemStage");
logger.verbose("Building stage: flamingock-system-stage");

String sourcesPackage = null;
String resourcesDir = null;
Expand All @@ -575,7 +577,7 @@ private SystemPreviewStage mapToSystemStage(Map<String, List<CodePreviewChange>>

// For system stage, use hardcoded name and description to maintain consistency
return PreviewStage.systemBuilder()
.setName("SystemStage")
.setName("flamingock-system-stage")
.setDescription("Dedicated stage for system-level changes")
.setSourcesRoots(sourceRoots)
.setSourcesPackage(sourcesPackage)
Expand Down
Loading