Initial Version of Couchbase driver#603
Conversation
|
Hi @babltiga , We are glad you raised this PR, we'll take a look soon and will help in anything you need. Thanks! |
babltiga
force-pushed
the
couchbase-driver
branch
2 times, most recently
from
8c8be82 to
a026eea
Compare
babltiga
force-pushed
the
couchbase-driver
branch
from
a026eea to
29f8db3
Compare
|
Hello @babltiga, we have been started the review of the PR, we'll let you know as soon as possible. Thanks. |
osantana85
left a comment
osantana85
left a comment
There was a problem hiding this comment.
Hello @babltiga, great job! I added a few comments, most of them minor changes. If you need more details please let me know. Thanks!
...ase-driver/src/main/java/io/mongock/driver/couchbase/repository/CouchbaseLockRepository.java
Outdated
Show resolved
Hide resolved
...ase-driver/src/main/java/io/mongock/driver/couchbase/repository/CouchbaseLockRepository.java
Outdated
Show resolved
Hide resolved
...ase-driver/src/main/java/io/mongock/driver/couchbase/repository/CouchbaseLockRepository.java
Outdated
Show resolved
Hide resolved
...ase-driver/src/main/java/io/mongock/driver/couchbase/repository/CouchbaseRepositoryBase.java
Show resolved
Hide resolved
.../src/main/java/io/mongock/driver/couchbase/springboot/config/CouchbaseSpringbootContext.java
Show resolved
Hide resolved
...ase-driver/src/main/java/io/mongock/driver/couchbase/repository/ChangeEntryKeyGenerator.java
Outdated
Show resolved
Hide resolved
...ase-driver/src/main/java/io/mongock/driver/couchbase/repository/CouchbaseRepositoryBase.java
Outdated
Show resolved
Hide resolved
...ase-driver/src/main/java/io/mongock/driver/couchbase/repository/CouchbaseRepositoryBase.java
Outdated
Show resolved
Hide resolved
Changed the couchbase key prefix. Change the doctype file name. Changed the doctype key value for change sets.
osantana85
left a comment
osantana85
left a comment
There was a problem hiding this comment.
Hello @babltiga , thanks for your changes. Most of the requests are solved. I've added a few new comments. Good job!
...ase-driver/src/main/java/io/mongock/driver/couchbase/repository/CouchbaseRepositoryBase.java
Outdated
Show resolved
Hide resolved
...ase-driver/src/main/java/io/mongock/driver/couchbase/repository/CouchbaseRepositoryBase.java
Outdated
Show resolved
Hide resolved
...se/couchbase-driver/src/main/java/io/mongock/driver/couchbase/util/CouchbaseVersionUtil.java
Show resolved
Hide resolved
Add missing dependency into community-bom.
osantana85
left a comment
osantana85
left a comment
There was a problem hiding this comment.
Hello @babltiga , sorry for the delay, but this week we have been a bit busy releasing Mongock's version 5.2.4 (solving a few issues).
The PR is almost ok to merge. I added a comment related to LockEntry documents key prefix.
Additionally, could you rebase/merge latest Mongock's changes to your PR branch? Currently version of modules should be 5.2.5-SNAPSHOT (now yours are 5.2.3-SNAPSHOT).
Thanks in advance.
osantana85
left a comment
osantana85
left a comment
There was a problem hiding this comment.
Hello @babltiga , your PR is approved to merge. Thanks for your great job.
3 participants
Issue reference
New Driver Implementation
Documentation PR reference
flamingock/mongock-docs#42
Examples PR reference
flamingock/mongock-examples#50
Description and context
Couchbase Driver implementation supporting Couchbase Server 6+ (may also support the earlier once but tests are executed against v6 and v7).
Benefits
New Driver backed by Couchbase server.
Possible Drawbacks
None
Checklist