Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to override imgur key #2503

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Allow users to override imgur key #2503

merged 2 commits into from
Mar 30, 2022

Conversation

borgmanJeremy
Copy link
Contributor

No description provided.

@mmahmoudian
Copy link
Member

This is the error I got when changed one character of the default API key (the one in upper-case is what I changed to: 313baf0c7b4F3ff):

image

Is there a way to validate an API key?

@veracioux
Copy link
Contributor

veracioux commented Mar 29, 2022 •
edited
Loading

@mmahmoudian Isn't the message you received validation in itself?

@mmahmoudian
Copy link
Member

User gets this message after they have selected the screenshot area and potentially annotated it. Basically it causes the user to lose all the progress. What I suggest is that we validate the key upon change on the settings so that the user gets the error right at that time and before potentially losing valuable information.

@borgmanJeremy
Copy link
Contributor Author

User gets this message after they have selected the screenshot area and potentially annotated it. Basically it causes the user to lose all the progress. What I suggest is that we validate the key upon change on the settings so that the user gets the error right at that time and before potentially losing valuable information.

Yeah I can do that. I'll have it try to upload a one pixel image when the key changes and then return an error if that fails.

@borgmanJeremy borgmanJeremy mentioned this pull request Mar 30, 2022
Closed
@borgmanJeremy
Copy link
Contributor Author

User gets this message after they have selected the screenshot area and potentially annotated it. Basically it causes the user to lose all the progress. What I suggest is that we validate the key upon change on the settings so that the user gets the error right at that time and before potentially losing valuable information.

Yeah I can do that. I'll have it try to upload a one pixel image when the key changes and then return an error if that fails.

Actually its going to be more work than I expected to validate it. I'm going to punt on that given the recent plugin discussion.

@borgmanJeremy borgmanJeremy merged commit c01ffec into master Mar 30, 2022
@borgmanJeremy borgmanJeremy deleted the imgur_api_key branch May 2, 2022 00:27
panpuchkov pushed a commit to namecheap/flameshot that referenced this pull request May 13, 2022
@borgmanJeremy
Allow users to override imgur key (flameshot-org#2503)
6372df2 
* Allow users to override imgur key

* Remove debug statements

(cherry picked from commit c01ffec)
@thehunmonkgroup thehunmonkgroup mentioned this pull request Jun 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@borgmanJeremy @mmahmoudian @veracioux