Pinch gesture on pinned screenshot #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borgmanJeremy
approved these changes
Feb 23, 2022
panpuchkov
pushed a commit
to namecheap/flameshot
that referenced
this pull request
May 13, 2022
* Minor refactoring * Pinch gesture works fine * Consolidated Zooming in/out * Minor refactoring * Minor refactoring * clang-format * Fixed scroll phases on Linux * clang-format * Re-added size constraint * clang-format (cherry picked from commit 413a3f9)
|
Not able to zoom pinned images in V12 via mouse scroll, it conflicts with "Change tool size Option" which is the new default action for mouse scroll. |
Sorry for the late reply. Using Flameshot v12.1.0 (001726a) I don't have any issue resizing it in X11. If you have the issue and you are on the latest version (at least |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinned image can be zoomed in/out via scrolling the mouse or, if supported, by pinching gesture. Refactored a bit the code.
I couldn't test it on Windows.
Tested on Mac OS Monterey and Ubuntu linux 18.04.