Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zooming in/out happens at different speed #2378

Merged

Conversation

AndreaMarangoni
Copy link
Contributor

@AndreaMarangoni AndreaMarangoni commented Feb 6, 2022

What I have done:

  • Removed magic number ex. +15/-15
  • Calculating the necessary steps (in pixels) from the QWheelEvent.
  • Using same aspect ratio during zooming in/out
  • Refactoring

I have tested it on Ubuntu 18.04 and Mac OS Monterey, but if someone could kindly test this on other devices that would be great.

Copy link
Contributor

@borgmanJeremy borgmanJeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@borgmanJeremy borgmanJeremy merged commit 1bacc69 into flameshot-org:master Feb 6, 2022
panpuchkov pushed a commit to namecheap/flameshot that referenced this pull request May 13, 2022
* Resizing pinned screenshot

* Zooming in/out on pinned screenshot

* Minor refactoring

* clang-format

(cherry picked from commit 1bacc69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants