Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors when generating flameshot.icons #2026

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Fix errors when generating flameshot.icons #2026

merged 1 commit into from
Oct 30, 2021

Conversation

sryze
Copy link
Contributor

@sryze sryze commented Oct 30, 2021

On macOS when you configure Flameshot with CMake it produces errors during generation of the iconset file:

mkdir build/xcode
cd build/xcode
cmake ../../ -G Xcode
Warning: ../data/img/app/flameshot.png not a valid file - skipping
Warning: ../data/img/app/flameshot.png not a valid file - skipping
Warning: ../data/img/app/flameshot.png not a valid file - skipping
Warning: ../data/img/app/flameshot.png not a valid file - skipping
Warning: ../data/img/app/flameshot.png not a valid file - skipping
Warning: ../data/img/app/flameshot.png not a valid file - skipping
Warning: ../data/img/app/flameshot.png not a valid file - skipping
Warning: ../data/img/app/org.flameshot.Flameshot-1024.png not a valid file - skipping
Warning: ../data/img/app/org.flameshot.Flameshot-1024.png not a valid file - skipping
Warning: ../data/img/app/org.flameshot.Flameshot-1024.png not a valid file - skipping
Warning: ../data/img/app/org.flameshot.Flameshot-1024.png not a valid file - skipping
Warning: ../data/img/app/org.flameshot.Flameshot-1024.png not a valid file - skipping
flameshot.iconset:Failed to generate ICNS.
cp: ../packaging/macos/flameshot.icns: No such file or directory
-- Found Git: /usr/bin/git (found version "2.30.1 (Apple Git-130)")
git found: /usr/bin/git in version     2.30.1 (Apple Git-130)
FLAMESHOT_GIT_HASH: a1e6a2f
-- Configuring done
CMake Error at src/CMakeLists.txt:55 (add_executable):
  Cannot find source file:

    /Users/szx/Sources/flameshot/build/xcode/flameshot.icns

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
  .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc

Solution: instead of a relative path ../data/ use ${CMAKE_SOURCE_DIR}/data/

@veracioux
Copy link
Contributor

@sryze Thanks :)

@veracioux veracioux merged commit d5ac6e0 into flameshot-org:master Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants