Skip to content

Commit

Permalink
blacklist ICC 18 for knl/skx due to test failures
Browse files Browse the repository at this point in the history 
Signed-off-by: Jeff Hammond <jeff.r.hammond@intel.com>
  • Loading branch information
@jeffhammond
Jeff Hammond authored and jeffhammond committed Jan 4, 2020
1 parent af3589f commit 6433831
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions configure
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1446,6 +1446,10 @@ check_compiler()
blacklistcc_add "skx"
fi
fi
if [ ${cc_major} -eq 18 ]; then
echo "${script_name}: ${cc} ${cc_version} is known to cause erroneous results. See https://github.com/flame/blis/issues/371 for details."
blacklistcc_add "knl"
blacklistcc_add "skx"
if [ ${cc_major} -ge 19 ]; then
echo "${script_name}: ${cc} ${cc_version} is known to cause erroneous results. See https://github.com/flame/blis/issues/371 for details."
echoerr_unsupportedcc
Expand Down

3 comments on commit 6433831

@fgvanzee
Copy link
Member

@fgvanzee fgvanzee commented on 6433831 Jan 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffhammond Your missing fi broke configure, along with all Travis CI tests. :)

I will fix.

@fgvanzee
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I did sign off on your changes, so I was accomplice to the breakage, but that only goes to show that even people who have been doing this for a while fail at eyeballing code changes.

Perhaps it would be best to either push everything through a PR so that Travis CI can chew on it, OR make sure you configure; make; make test before committing.

@jeffhammond
Copy link
Member

@jeffhammond jeffhammond commented on 6433831 Jan 7, 2020 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.