Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Un-export Timer #90

Merged
merged 2 commits into from
Mar 13, 2024
Merged

refactor!: Un-export Timer #90

merged 2 commits into from
Mar 13, 2024

Conversation

ufrshubham
Copy link
Member

Description

This PR removes the internal Timer class from the exports. It is a very simple wrapper over the Stopwatch API and does not provide any additional functionality. But it does causes conflicts when try to use Flame's Timer or dart:async's Timer. By not exporting it, we can save the users from these conflicts.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@spydon spydon merged commit abf2378 into main Mar 13, 2024
3 checks passed
@spydon spydon deleted the devkage/timer-conflict branch March 13, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants