fix: Create and destroy joints after world has been locked

[spydon]

Description

This fixes so that the queued up joints are actually created and destroyed when the world is stepped.

Checklist

• The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
• I have read the Contributor Guide and followed the process outlined for submitting PRs.
• I have updated/added tests for ALL new/updated/fixed functionality.
• I have updated/added relevant documentation in docs and added dartdoc comments with ///.
• I have updated/added relevant examples in examples.

Breaking Change

• Yes, this is a breaking change.
• No, this is not a breaking change.

Related Issues

[drrnbrns]

As requested, I tried this branch locally and yes, it does appear to fix the issue I encountered. Joints are now created as expected (I didn't try destroying joints but the code looks good to me).

Since earlier versions just asserted that the world wasn't locked, my project has always queued such operations. When adding new code, I just forgot to queue and hit the issue. So I won't actually depend on this fix since I'll continue to queue operations myself, but I think it's definitely a good fix to have.

Note that making the lists private is technically a breaking change, but it's unlikely anyone would access them.

Thank you for the speedy update!

[spydon]

Note that making the lists private is technically a breaking change, but it's unlikely anyone would access them.

Yeah, I had the same thinking, so didn't mark it as breaking.

I'll publish a new version once I get a review from someone else in the team.

[luanpotter]

did this just... never worked? haha

[spydon]

Haha yeah, but it's quite new

[luanpotter]

LGTM

[spydon]

@drrnbrns it's now released :)

[drrnbrns]

@drrnbrns it's now released :)

@spydon Thanks a lot for the high-quality fix (i.e. with tests) in less than 24 hours!