Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove deprecated gh-pages build argument #3526

Merged
merged 1 commit into from
Mar 13, 2025
Merged

chore: Remove deprecated gh-pages build argument #3526

merged 1 commit into from
Mar 13, 2025

Conversation

spydon
Copy link
Member

@spydon spydon commented Mar 13, 2025

Description

The web-renderer isn't needed anymore, and let's try to use the wasm compiler for the examples by default.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

luanpotter
luanpotter approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

Benchmark Results

Package flame:

Benchmarks Current Branch
[chore/gh-pages]		 Base Branch
[main]		 Diff
Render Components Benchmark 981.772 μs 1009.043 μs 🟢 -2.703 %
Updating Components Benchmark 341573.833 μs 343877.333 μs 🟢 -0.670 %

Benchmarks provided with 💙 by Dart Benchmark Action.

@spydon spydon enabled auto-merge (squash) March 13, 2025 03:02
@spydon spydon merged commit ccb5cf0 into main Mar 13, 2025
9 checks passed
@spydon spydon deleted the chore/gh-pages branch March 13, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luanpotter luanpotter luanpotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spydon @luanpotter