Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #248

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Update documentation #248

merged 2 commits into from
Jun 27, 2023

Conversation

MaxDall
Copy link
Collaborator

@MaxDall MaxDall commented Jun 26, 2023

The updates the attribute_guidelines and how_to_contribute markdowns to the latest changes and adds some additional sections.

@MaxDall MaxDall added the documentation Improvements or additions to documentation label Jun 26, 2023
@Weyaaron Weyaaron merged commit 15f7178 into master Jun 27, 2023
@MaxDall
Copy link
Collaborator Author

MaxDall commented Jun 27, 2023

@Weyaaron That's a bit too quick I think. Did you read through the changes in how_to_contribute.md before approving? They are not rendered by default.

@Weyaaron
Copy link
Collaborator

I agree, I fucked this up. The file has not been rendered and I missed the changes. I have no strong opinion on how to proceed.

@dobbersc
Copy link
Collaborator

We can still revert the merge. GitHub has a delete button next to your merg commit.

dobbersc added a commit that referenced this pull request Jun 27, 2023
@dobbersc
Copy link
Collaborator

Moved to #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants