Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle TimelineRangeOffsets (rangeStart / rangeEnd) #121

Merged
merged 8 commits into from
Aug 17, 2023

Conversation

bramus
Copy link
Collaborator

@bramus bramus commented Aug 17, 2023

This PR updates how the polyfill handles offsets:

  • Rename the delay/endDelay options to rangeStart/rangeEnd, as per spec.
  • Remove timeRange option
  • Remove animation-delay and animation-end-delay parsing from the CSS parser. Authors should use animation-range.
  • Internally rename timeRange to animateRange and ANIMATION_DELAY_NAMES to ANIMATION_RANGE_NAMES
  • Add support for px values as the range offset along the way

Fixes #64

@bramus bramus changed the title Handle TimelineRangeOffsets Correctly handle TimelineRangeOffsets (rangeStart / rangeEnd) Aug 17, 2023
Copy link
Collaborator

@kevers-google kevers-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bramus.

@kevers-google kevers-google merged commit 406adf4 into flackr:master Aug 17, 2023
@bramus bramus deleted the rename-delays-to-ranges branch September 13, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScrollTimeline offsets are no longer respected after last update.
2 participants