Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix for redirect loop in case of user w/o roles #1354

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Mar 19, 2025

removes role requirements from root / (home) endpoint to fix redirect loop for users without roles when authentication is enabled. The user still needs to log in to view the page, though.

resolves #1353

@jstucke jstucke added the bug label Mar 19, 2025
@jstucke jstucke requested a review from dorpvom March 19, 2025 13:18
@jstucke jstucke self-assigned this Mar 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.65%. Comparing base (c3f2ecc) to head (086281f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
- Coverage   92.55%   91.65%   -0.91%     
==========================================
  Files         385      374      -11     
  Lines       24865    21031    -3834     
==========================================
- Hits        23013    19275    -3738     
+ Misses       1852     1756      -96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dorpvom dorpvom merged commit a709ed6 into master Mar 31, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled behavior on user login when no role is given
3 participants