Skip to content

tree structure for comparison changed text files #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Oct 7, 2024

No description provided.

@jstucke jstucke added the gui label Oct 7, 2024
@jstucke jstucke self-assigned this Oct 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 43.58974% with 22 lines in your changes missing coverage. Please review.

Project coverage is 91.70%. Comparing base (ab95ac5) to head (84d1f26).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
src/web_interface/filter.py 38.88% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1279      +/-   ##
==========================================
- Coverage   92.48%   91.70%   -0.79%     
==========================================
  Files         379      376       -3     
  Lines       24115    21040    -3075     
==========================================
- Hits        22302    19294    -3008     
+ Misses       1813     1746      -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@euwint euwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few change requests:

  1. wider “show file diff” buttons so that the text fits in one line.
  2. reduction of the highlighting so that it no longer looks so wild or restless when you hover over objects with the mouse
  3. inserting folder and file type icons so that the look is closer to the FACT-typical file tree

Further note: We should also think about changing the appearance of the lower tables “files in common” and “non-zero files in common”! Perhaps we could also remove the “files in common” table.

Copy link
Collaborator

@euwint euwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better

@jstucke jstucke merged commit 1147a8b into master Feb 14, 2025
10 checks passed
@jstucke jstucke deleted the ctf-tree-poc branch February 14, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants