-
-
Notifications
You must be signed in to change notification settings - Fork 29
Closed
Labels
Description
Is your feature request related to a problem? Please describe.
Currently setting "no compression" for the blobs still sets a custom compressor for value-log
:
Lines 84 to 87 in f04590d
let vlog_cfg = | |
value_log::Config::<MyBlobCache, MyCompressor>::new(MyBlobCache(config.cache.clone())) | |
.segment_size_bytes(config.blob_file_target_size) | |
.compression(MyCompressor(config.blob_compression)); |
This then skips this optimization here:
but instead needs to clone the data unnecessarily often (here and here). I think at least one of these memcpy
s is avoidable.
Describe the solution you'd like
I think the cleanest way would be to set the value-log
compressor to None
.
Describe alternatives you've considered
Pass the decompress
value owned instead of sliced/borrowed.
Additional context
-