Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live reload for Gradio demo #89

Merged
merged 16 commits into from
Aug 20, 2024
Merged

Live reload for Gradio demo #89

merged 16 commits into from
Aug 20, 2024

Conversation

juberti
Copy link
Contributor

@juberti juberti commented Aug 18, 2024

Fixes #80

Now, changes that you make during editing are reflected immediately in the demo. For this to work demo has to be a global object, so the main function has been removed (as recommended by gradio: https://www.gradio.app/guides/quickstart)

Also adds streaming of output tokens, using infer_stream and queueing.

Also adds streaming of output tokens.
@juberti
Copy link
Contributor Author

juberti commented Aug 18, 2024

Reviewing this PR will be easier if you check "ignore whitespace" in the PR settings.

Justfile Show resolved Hide resolved
Copy link
Contributor

@farzadab farzadab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get to try the demo yet. The changes looked good though. I'll let ZQ be the main reviewer.

ultravox/tools/gradio_demo.py Show resolved Hide resolved
ultravox/inference/infer.py Outdated Show resolved Hide resolved
ultravox/inference/infer.py Show resolved Hide resolved
ultravox/inference/infer.py Show resolved Hide resolved
ultravox/inference/infer.py Outdated Show resolved Hide resolved
juberti and others added 6 commits August 20, 2024 14:41
Co-authored-by: zqhuang211 <zqhuang@gmail.com>
Co-authored-by: zqhuang211 <zqhuang@gmail.com>
Copy link
Contributor

@zqhuang211 zqhuang211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Streaming output looks very nice!

@juberti juberti enabled auto-merge (squash) August 20, 2024 23:31
@juberti juberti merged commit cb488b9 into main Aug 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update gradio demo to support streaming output
3 participants