Fix TypeError: non-default argument 'template' follows default argument, and filter out audio #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
liPatrick
commented
Aug 5, 2024
•
liPatrick
commented
- Fixes TypeError: non-default argument 'template' follows default argument
- Filters out audio before passed into jinja template to prevent memory spikes when using ds_tool.py
zqhuang211
reviewed
Aug 6, 2024
juberti
reviewed
Aug 6, 2024
farzadab
reviewed
Aug 7, 2024
|
Thanks for the fixes btw Pat. |
liPatrick
changed the title
juberti
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.