Minor fixes to ds_tool and infer_tool #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
juberti
commented
Jun 23, 2024
juberti
commented
- --upload_split param to allow the dest split to be different than the src split
- allow @file syntax for --prompt
- add retries and timeouts to TTS requests
- --upload_split param to allow the dest split to be different than the src split - allow @file syntax for --prompt - add retries and timeouts to TTS requests
farzadab
approved these changes
Jun 24, 2024
farzadab
reviewed
Jun 24, 2024
| @@ -150,6 +159,7 @@ def main(args: DatasetToolArgs): | |||
| "token": token, | |||
| "revision": args.upload_branch, | |||
| "private": args.private, | |||
| "split": args.upload_split, | |||
There was a problem hiding this comment.
Wait, you didn't fix the conflict here!
Now on line 170 you'll be sending the split argument twice, and with different values!
farzadab
reviewed
Jun 24, 2024
Comment on lines
+134
to
+136
| assert ( | ||
| not self.upload_split or self.dataset_split | ||
| ), "Must specify dataset_split when using upload_split" |
There was a problem hiding this comment.
Sorry I didn't catch this the first time, but why can't upload_split be equal to dataset_split by default if not specified?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.