-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SODA Dataset for Training #35
Conversation
6248f64
to
5ba015c
Compare
The PR is ready. |
5ba015c
to
e4ec48a
Compare
ultravox/data/datasets.py
Outdated
roles = ["user", "assistant"] if len(turns) % 2 == 0 else ["assistant", "user"] | ||
|
||
num_prompts = min(self._args.num_prompts, len(self.SYS_PROMPTS)) | ||
sys_prompt = self.SYS_PROMPTS[idx % num_prompts] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we end up using a RNG for this sort of thing rather than the index?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I forget where but we discussed adding a private RNG to datasets to allow them to simply pull a value from the RNG rather than using the index counter and various moduli)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the idea was that we do that in the next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well just do it now I guess since I have the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
for column_name in self.BASE_AUDIO_COLUMNS: | ||
dataset = dataset.cast_column( | ||
column_name, datasets.Audio(sampling_rate=SAMPLE_RATE) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bugfix for datasets that have audio column that is not named audio
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not an issue for SODA since it was constructed with 16K Hz, but it was sloppy of me.
No description provided.