Local tokenizer and processor for more consistent CI #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farzadab
changed the title
juberti
approved these changes
Jun 7, 2024
|
Still seeing failures here even with local tokenizer/processor. I think something is getting wedged during test shutdown, kind of frustrating to debug since everything works fine locally 🙁 |
|
OK, so the issue here was ddp_utils_test.py, not infer_test.py. That said, I think this is worth keeping since it allows external PRs to access the Llama 3 tokenizer, which would otherwise fail due to not having the HF_TOKEN set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.