Not uploading text_config when text_model_id is present #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggests, removing
text_configwhentext_model_idis present, sincetext_configwill be overwritten and its existence can be confusing.This PR is in partial response to this comment on Discord by Hyunsung Lee:
I should note that this PR doesn't quite address this comment, but simply improves another confusion that can arise later down the line when people try to update text_config but see it doesn't actually do anything.
Example config (revision of a private repo): https://huggingface.co/fixie-ai/ultravox-v0_4-llama-3_1-70b/blob/4cfd42ee20b5c2df2065d25a223ff10bfaf0d728/config.json
