Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AutoProcessor registration #102

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Add AutoProcessor registration #102

merged 1 commit into from
Aug 28, 2024

Conversation

petersalas
Copy link
Contributor

UV 0.4 doesn't currently register the processor.

Copy link
Contributor

@farzadab farzadab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch.
That's so confusing. You'd think AutoProcessor.register is enough, but I guess it's not.

@petersalas petersalas merged commit 84fc928 into main Aug 28, 2024
1 check passed
@petersalas petersalas deleted the psalas/auto-processor branch August 28, 2024 18:43
@farzadab
Copy link
Contributor

Actually, looking at the code of ultravox_processing.py, I don't see from_pretraiend which suggests that I didn't use main branch to push the model.

@farzadab
Copy link
Contributor

farzadab commented Aug 28, 2024

@petersalas will you update the two files (ultravox_processin.py and config.json) on ultravox-v0_4 or should I?
It's possible that we didn't need the extra register tbh.

@petersalas
Copy link
Contributor Author

petersalas commented Aug 28, 2024

Oh I see -- do you have (can you land) the other changes we need for from_pretrained?

@farzadab
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants