Tags: fix2015/NemoClaw
Tags
fix(e2e): stage device auth through hosted inference (NVIDIA#6071) <!-- markdownlint-disable MD041 --> ## Summary Fixes the `device-auth-health` live E2E wiring so the repo `NVIDIA_INFERENCE_API_KEY` is staged through the shared hosted-compatible inference config instead of being validated as the public NVIDIA endpoint provider. The install helper now starts each install attempt with `--fresh` so Vitest retries do not fail on leftover failed onboarding session state. ## Related Issue Fixes NVIDIA#2342 ## Changes - Stage `device-auth-health` installs with `requireHostedInferenceConfig`, including `COMPATIBLE_API_KEY`, `NEMOCLAW_PROVIDER=custom`, and the hosted-compatible default endpoint/model. - Run the live install path with `install.sh --non-interactive --fresh` to prevent retry attempts from tripping the failed-session guard. - Add E2E support coverage for the helper env contract and install arguments. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates <!-- Check all that apply. For any "covered by existing tests", "not applicable", or waiver entry, add a brief justification on the same line or in the Changes section. --> - [x] Tests added or updated for changed behavior - [ ] Existing tests cover changed behavior — justification: - [ ] Tests not applicable — justification: - [ ] Docs updated for user-facing behavior changes - [x] Docs not applicable — justification: internal E2E CI wiring only; no user-facing behavior change - [x] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [x] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: self-reviewed credential/inference test wiring; secrets are still passed only via fixture env and redaction values - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Verification <!-- Check each item you ran and confirmed. Leave unchecked items you skipped. Doc-only changes do not require npm test unless you ran it. --> - [x] PR description includes the DCO sign-off declaration and every commit appears as `Verified` in GitHub - [ ] Git hooks passed during commit and push, or `npx prek run --from-ref main --to-ref HEAD` passes - [x] Targeted tests pass for changed behavior - [ ] Full `npm test` passes (broad runtime changes only) - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) Verification run: - `npx @biomejs/biome check test/e2e/live/device-auth-health-helpers.ts test/e2e/support/device-auth-health-helpers.test.ts` - `npx vitest run --project e2e-support test/e2e/support/device-auth-health-helpers.test.ts test/e2e/support/hosted-inference.test.ts --silent=false --reporter=default` - `npm run build:cli && npm run typecheck:cli` - Commit hook ran with `SKIP=test-cli`; the broad CLI coverage hook failed unrelated local macOS environment checks requiring GNU `timeout`, privileged control paths, and shell assumptions. Push TypeScript hooks passed, and targeted tests above passed. --- <!-- DCO sign-off is required in this PR description, and every commit must appear as Verified in GitHub. Run: git config user.name && git config user.email --> Signed-off-by: Julie Yaunches <jyaunches@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved device auth health setup to correctly use hosted inference credentials when available. * Updated sandbox installation to use a fresh install path during retries, helping avoid stale setup issues. * Added coverage for hosted inference environment wiring and install behavior to improve reliability of end-to-end checks. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
PreviousNext