-
Notifications
You must be signed in to change notification settings - Fork 8
Replace Slack API with Amazon Q, to allow usage of Microsoft teams and Amazon Chime #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kuznetsov-Aleksandr-A
wants to merge
14
commits into
fivexl:main
Choose a base branch
from
Kuznetsov-Aleksandr-A:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces the Slack API integration with Amazon Q to support Microsoft Teams and Amazon Chime notifications. Key changes include:
- Updating documentation for Slack, Teams, and Chime integration.
- Adding a new IAM module README.
- Reworking the notification function to publish messages to SNS for Amazon Q.
Reviewed Changes
Copilot reviewed 13 out of 28 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/slack_workspace/README.md | Adds documentation for Slack workspace configuration. |
| modules/iam/README.md | Introduces IAM module documentation for Chatbot configuration. |
| functions/amazon_q_notifications.py | Refactors notification logic to use SNS for Amazon Q. |
| README.md | Updates overall module documentation and examples for multi-chat integration. |
Files not reviewed (15)
- amazon_q.tf: Language not supported
- examples/complete/main.tf: Language not supported
- examples/complex/main.tf: Language not supported
- examples/container-instance-state/main.tf: Language not supported
- examples/simple-secretsmanager/main.tf: Language not supported
- examples/simple-ssm_parameter/main.tf: Language not supported
- examples/simple/main.tf: Language not supported
- functions/requirements.txt: Language not supported
- main.tf: Language not supported
- modules/iam/main.tf: Language not supported
- modules/iam/outputs.tf: Language not supported
- modules/iam/variables.tf: Language not supported
- modules/iam/versions.tf: Language not supported
- modules/slack_workspace/main.tf: Language not supported
- modules/slack_workspace/variables.tf: Language not supported
Comments suppressed due to low confidence (2)
functions/amazon_q_notifications.py:260
- Returning the SNS publish response wrapped in json.dumps with a 'code' key may not accurately represent the actual SNS response structure. Consider returning the SNS response directly or extracting and returning a specific, meaningful field (e.g., MessageId).
return json.dumps({"code": response})
README.md:59
- The inline comment for 'channel_id' appears to be swapped with 'workspace_id'. Ensure that 'channel_id' is documented with the Slack channel ID and 'workspace_id' with the Slack workspace ID to avoid confusion.
channel_id = "1234567890" # Your Slack workspace ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.