Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ad history #39

Merged
merged 15 commits into from
Mar 13, 2025
Merged

Update ad history #39

merged 15 commits into from
Mar 13, 2025

Conversation

fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Mar 10, 2025

PR Overview

This PR will address the following Issue/Feature: #37

Submission Checklist

Submitter:

  • Alignment meeting with the reviewer
  • Provide validation details:
    • Validation Steps: See internal ticket

    • [] Testing Instructions: Clear steps for running/testing (e.g., scripts, sample data)

See internal ticket

  • [] Focus Areas: na

Reviewer:

  • [] Confirm submission requirements are met

Changelog

  • [] Draft after PR approval

Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very good! some doc comments

Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-reneeli fivetran-reneeli merged commit 3b46401 into main Mar 13, 2025
8 checks passed
@fivetran-reneeli fivetran-reneeli deleted the update_ad_history branch March 13, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants