Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current_date changed to dbt_utils.current_timestamp_in_utc #47

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

This PR introduces the use of the dbt_utils.current_timestamp_in_utc macro in place of the current_date warehouse function within the int_jira__issue_calendar_spine model. This is due to issues some users were experiencing with the package not providing accurate date timestamps in certain regions.

As Fivetran syncs the data in UTC it makes sense to use the UTC timezone in the calendar spine as well.

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide explanation how the change is non breaking below.)

This will need to result in a breaking change since the update is being made to the int_jira__issue_calendar_spine model which is incremental. As such, a --full-refresh will be needed to be executed by users in order for the change to be appropriately reflected in their output model.s

Is this PR in response to a previously created Issue

How did you test the PR changes?

  • CircleCi
  • Other (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-joemarkiewicz
Copy link
Contributor Author

Based off @RivkiHofman testing on their local branch, I am comfortable merging this into the release branch.

@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the base branch from main to release/v0.6.0 December 1, 2021 17:34
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 35c0636 into release/v0.6.0 Dec 1, 2021
@fivetran-joemarkiewicz fivetran-joemarkiewicz mentioned this pull request Dec 1, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant