Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query by referring to correct CTE #45

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

thibonacci
Copy link
Contributor

Are you a current Fivetran customer?

Thibault He, Senior BI Analyst, Onfido

What change(s) does this PR introduce?

A very tiny fix to int_jira__issue_assign_resolution

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide explanation how the change is non breaking below.)
    It won't break anything for anybody I believe, will only make downstream models more accurate.

Is this PR in response to a previously created Issue

  • Yes, Issue [link issue number here]
  • No

How did you test the PR changes?

  • CircleCi
  • Other (please provide additional testing details below)
    This is what I said on the dbt Slack: if we look at first_resolved_at for instance, my understanding is that there is always going to be a row for field_id = resolutiondate even for issues that have never been resolved, but in that case the value is null. Therefore we use the filtered CTE in order to exclude those rows, otherwise we will wrongly return an actual value for first_resolved_at when this should be null for non-resolved issues

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the base branch from main to release/v0.5.2 November 30, 2021 19:13
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @thibonacci 🎉

After our discussion in dbt Slack and reviewing your PR I am comfortable that this is an appropriate change to be integrated into the next release of the package. I'm extremely grateful you raised this and opened a PR to address the issue. Now the entire community get's to benefit! 😄

Thanks again and keep an eye on the merge branch to see when this will be integrated into the next release!

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 2fdb421 into fivetran:release/v0.5.2 Nov 30, 2021
This was referenced Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants