Fix query by referring to correct CTE #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
Thibault He, Senior BI Analyst, Onfido
What change(s) does this PR introduce?
A very tiny fix to
int_jira__issue_assign_resolution
Does this PR introduce a breaking change?
It won't break anything for anybody I believe, will only make downstream models more accurate.
Is this PR in response to a previously created Issue
How did you test the PR changes?
This is what I said on the dbt Slack: if we look at first_resolved_at for instance, my understanding is that there is always going to be a row for field_id = resolutiondate even for issues that have never been resolved, but in that case the value is null. Therefore we use the filtered CTE in order to exclude those rows, otherwise we will wrongly return an actual value for first_resolved_at when this should be null for non-resolved issues
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.